Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update F2.html #4128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update F2.html #4128

wants to merge 5 commits into from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Nov 1, 2024

  • rephrased the introduction to include mention of assistive technology
  • removed example 3
  • updated outcome logic of checks 1 and 2
  • added a third condition to check 2

Resolves #4109

- removed example 3
- updated outcome logic of checks 1 and 2
- added a third condition to check 2
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 46dca6c
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/672521988eff170008620a05
😎 Deploy Preview https://deploy-preview-4128--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

techniques/failures/F2.html Outdated Show resolved Hide resolved
mbgower and others added 2 commits November 1, 2024 06:36
modified the introduction to include the third check in test 2
@mbgower mbgower self-assigned this Nov 1, 2024
techniques/failures/F2.html Outdated Show resolved Hide resolved
@@ -1,7 +1,7 @@
<!DOCTYPE html><html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml"><head><title>Failure of Success Criterion 1.3.1 due to using changes in text presentation to convey information without using the appropriate markup or text</title><link rel="stylesheet" type="text/css" href="../../css/editors.css" class="remove"/></head><body><h1>Failure of Success Criterion 1.3.1 due to using changes in text presentation to convey information without using the appropriate markup or text</h1><section class="meta"><p class="id">ID: F2</p><p class="technology">Technology: failures</p><p class="type">Type: Failure</p></section><section id="applicability"><h2>When to Use</h2>
<p>All technologies that support images or presentation markup.</p>
</section><section id="description"><h2>Description</h2>
<p>This document describes a failure that occurs when a change in the appearance of text conveys meaning without using appropriate semantic markup. This failure also applies to images of text that are not enclosed in the appropriate semantic markup.</p>
<p>This document describes a failure that occurs when a change in the appearance of text conveys meaning without using appropriate semantic markup, or without using text styling that is conveyed by assistive technology. This failure also applies to images of text that are not enclosed in the appropriate semantic markup.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(per TF discussion) It feels off to add this clause when the rest of the PR is specifically removing the only example where it would apply. In the headings examples, it wouldn't be sufficient for ATs to convey a change in text styling; that wouldn't be sufficient to convey the semantic heading structure.

I would lean more towards updating the technique to more specifically talk about not using non-semantic visual techniques to present stuff that looks semantically relevant (the 2 remaining examples with headings are good, could also add something like "using a left-margin and images instead of a semantic list to indicate a list" if we want a non-heading example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks @dbjorge.

I will pull back on additive material for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbjorge please re-review so this can be merged if/when supported by WG.

@bruce-usab
Copy link
Contributor

Discussed on backlog call 11-1. Concern on call with only having heading examples, since CSS can semantically be used to convey emphasis.

Pulled back expansion of the failure technique to include presentation markup detected by assistive technologies.
@mbgower
Copy link
Contributor Author

mbgower commented Nov 1, 2024

Created a new issue to track unincorporated changes #4132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe remove Example 3 of F2
3 participants