Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech timeout 20 hours or greater #4058

Closed
wants to merge 9 commits into from

Conversation

patrickhlauke
Copy link
Member

This branch never had a pull request made. Suggest we either take/consider this, or delete both this PR and branch.

Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 6de837a
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/67127a8ad0a6920009499ac9
😎 Deploy Preview https://deploy-preview-4058--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bruce-usab
Copy link
Contributor

Discussed on TF call 9/13. This would be new technique from a stale branch. TBD.

@bruce-usab
Copy link
Contributor

@goodwitch are you still of the opinion that this is an important gap to fill? That is, do we need a technique for testing that a timeout does not occur within 20 hours? And if so, is what @patrickhlauke has drafted sufficient? Thank you.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Sep 13, 2024

And if so, is what @patrickhlauke has drafted sufficient?

to clarify, this is literally just taking the branch that @goodwitch opened at the time and turning it into a PR. it will need massaging to be mergeable

@bruce-usab
Copy link
Contributor

On TF call 10/4, @alastc offered to ask @goodwitch offline about the need for this PR.

@patrickhlauke
Copy link
Member Author

I would suggest closing this (and deleting the branch), as we likely don't need a technique that literally says "to test there's a 20 hour timeout, set yourself a timer for 19 hours 59 minutes and check if anything happens in that last minute..."

@mbgower
Copy link
Contributor

mbgower commented Oct 18, 2024

Discussed on today's TF call. Attempts were made to contact creator. Closing as unnecessary.

@mbgower mbgower closed this Oct 18, 2024
@kfranqueiro kfranqueiro deleted the tech-timeout-20-hours-or-greater branch October 18, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants