Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

update ATAG Overview page -- Response to #21 #26

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Conversation

iadawn
Copy link
Contributor

@iadawn iadawn commented Nov 2, 2022

No description provided.

@iadawn
Copy link
Contributor Author

iadawn commented Nov 2, 2022

@shawna-slh worth having a look at the line on remaining relevant?

@shawna-slh shawna-slh changed the title Response to #21 update ATAG Overview page -- Response to #21 Nov 4, 2022
@shawna-slh shawna-slh self-assigned this Nov 4, 2022
@shawna-slh
Copy link
Contributor

@SteveALee why failed?

@SteveALee
Copy link
Contributor

SteveALee commented Dec 2, 2022

Because using old dependencies before fixing Dependency hell. The trouble with PRs is the target branch (master) is pointing at old version as it was created before the fixes pushed to master. Very confusing, see this GH issue

The best solution is to merge master into iadawn-patch-1 to update it. Let me see if can do.

@SteveALee SteveALee changed the base branch from master to atag-briefs December 2, 2022 11:28
@SteveALee SteveALee changed the base branch from atag-briefs to master December 2, 2022 11:28
@SteveALee SteveALee changed the base branch from master to atag-briefs December 2, 2022 11:35
@SteveALee SteveALee changed the base branch from atag-briefs to example-delete December 2, 2022 11:37
@SteveALee SteveALee changed the base branch from example-delete to master December 2, 2022 11:37
@SteveALee
Copy link
Contributor

SteveALee commented Dec 2, 2022

@shawna-slh fixed. I created and merged a new PR in GH to merge master into iadawn-patch-1. You can see it in the history above. The Netlify preview build was triggered automatically by this.

@shawna-slh shawna-slh merged commit 1de2195 into master Dec 7, 2022
@shawna-slh shawna-slh deleted the iadawn-patch-1 branch December 7, 2022 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants