Update APG -> WAI pipeline workflows
#353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
howard-e
commented
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following:
main. Most likely changes to any "infrastructure" files. It shouldn't matter if changes are discarded on the branch because the site rebuild updates the static content on each new commit anyways (or attempts to).patch-{x}. This is easily distinguishable onaria-practicesbecause of the general context separation of a fork.wai-aria-practices, it comes through as justapg/patch-{x}.CONTRIBUTOR_AandCONTRIBUTOR_Bwere to create a PR from their respective forks with the default branch name GitHub provides, there could be a case where there is multipleapg/patch-{x}clashing so this PR creates that separation by having any fork created PR be generated asapg/{CONTRIBUTOR}-{BRANCH_NAME}.wai-aria-practicesto explicitly provide a commit status for a recently updated PR inaria-practicesso contributors can better understand that a build failure has happened (currently, scanning the top comment for "WAI Preview Link failed to build" is the only way how). However, this would be best to wait for a dedicated bot token be used.