-
Notifications
You must be signed in to change notification settings - Fork 112
Rename issuanceDate/expirationDate to validFrom/validUntil. #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please update the json schemas too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are also some sections that talk about expiry, expiration date etc. i guess we would have to update them too.
The issue was discussed in a meeting on 2022-12-14
View the transcript3.3. Rename issuanceDate/expirationDate to validFrom/validUntil. (pr vc-data-model#992)See github pull request vc-data-model#992. Manu Sporny: PR992 - rename issuanceDate/expiration date from validFrom/ValidUntil comments in the PR with a number of corrections. |
@decentralgabe wrote:
Done in: 1e38194 I'll note that keeping all of this in sync is going to be challenging. I don't think we have any other renames coming up. During the last call, we had noted that we wanted to automate the generation of the human-readable vocabulary file, JSON Schema, and a variety of other things. Multiple tools were suggested -- that issue is being tracked here: #998 |
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR implements a decision made by the VCWG to rename issuanceDate/expirationDate to validFrom/validUntil:
#913 (comment)
The PR also merges the
issuanceDate
andexpirationDate
sections into one due to unnecessary duplicated content, you can preview the new combined section (which only contains editorial changes) here:https://pr-preview.s3.amazonaws.com/w3c/vc-data-model/pull/992.html#validity-period
Preview | Diff