Skip to content

Rename issuanceDate/expirationDate to validFrom/validUntil. #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2022

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 11, 2022

This PR implements a decision made by the VCWG to rename issuanceDate/expirationDate to validFrom/validUntil:

#913 (comment)

The PR also merges the issuanceDate and expirationDate sections into one due to unnecessary duplicated content, you can preview the new combined section (which only contains editorial changes) here:

https://pr-preview.s3.amazonaws.com/w3c/vc-data-model/pull/992.html#validity-period


Preview | Diff

Copy link
Contributor

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update the json schemas too?

Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also some sections that talk about expiry, expiration date etc. i guess we would have to update them too.

@iherman
Copy link
Member

iherman commented Dec 14, 2022

The issue was discussed in a meeting on 2022-12-14

  • no resolutions were taken
View the transcript

3.3. Rename issuanceDate/expirationDate to validFrom/validUntil. (pr vc-data-model#992)

See github pull request vc-data-model#992.

Manu Sporny: PR992 - rename issuanceDate/expiration date from validFrom/ValidUntil comments in the PR with a number of corrections.

msporny and others added 2 commits December 18, 2022 16:18
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@msporny
Copy link
Member Author

msporny commented Dec 18, 2022

@decentralgabe wrote:

could you please update the json schemas too?

Done in: 1e38194

I'll note that keeping all of this in sync is going to be challenging. I don't think we have any other renames coming up. During the last call, we had noted that we wanted to automate the generation of the human-readable vocabulary file, JSON Schema, and a variety of other things. Multiple tools were suggested -- that issue is being tracked here: #998

@msporny
Copy link
Member Author

msporny commented Dec 18, 2022

@awoie wrote:

there are also some sections that talk about expiry, expiration date etc. i guess we would have to update them too.

Good catch @awoie, thank you!

I fixed all the remaining ones I could find. Fixed in 7522a1d.

@msporny msporny merged commit 5f74954 into main Dec 18, 2022
@msporny msporny deleted the msporny-rename-validity branch December 18, 2022 21:47
@msporny
Copy link
Member Author

msporny commented Dec 18, 2022

Normative, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants