Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to YAML vocabulary #968

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Upgrade to YAML vocabulary #968

merged 2 commits into from
Nov 5, 2022

Conversation

msporny
Copy link
Member

@msporny msporny commented Oct 28, 2022

This PR upgrades to the YAML vocabulary tool and removes the old library files.

* Switched to YAML for the vocab definition

* Deprecated terms well separated
@iherman
Copy link
Member

iherman commented Nov 2, 2022

The issue was discussed in a meeting on 2022-11-02

  • no resolutions were taken
View the transcript

1.1. IssuanceDate and ExpirationDate (pr vc-data-model#964)

See github pull request vc-data-model#964.

Manu Sporny: simultaneously ivan raised a PR to update vocabularies.

See github pull request vc-data-model#968.

Manu Sporny: and they conflict with one another.
… Ivan and Mahmoud you have to talk to each other.
… that is the only thing that keeps those PRs from being merged.

Ivan Herman: my PR does two things. one yaml is now the language and the other thing it also includes the changes of property names.
… should have made that more clear.
… as far as i could understand it duplicates what Mahmoud has done.
… apologies for that.
… that is where we are.

Manu Sporny: that is great because we have more people doing PRs.

@msporny
Copy link
Member Author

msporny commented Nov 5, 2022

Now that #964 is cleared, merging this PR.

@msporny
Copy link
Member Author

msporny commented Nov 5, 2022

Substantive, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 6bfde2b into main Nov 5, 2022
@msporny msporny deleted the iherman-yaml-vocab branch November 5, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants