-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain issuanceDate and don't introduce validFrom #918
Comments
The ideal situation would be...
+1 for keeping a property that allows us to identify when a VC was issued. I guess that was already anticipated in VC Data Model 1.1:
I'm happy to create a PR that makes those changes to the VC Data Model. |
We should be careful to avoid standardizing "suite metadata" in the core data model... When a signature was applied (according to the issuer) might not belong in the core data model if we have better layering. issuanceDate, today, is really the date the claims are meant to be valid... Not the date the credential was secured with JWT or Data Integrity... An issuer might want to signal both dates with clarity... In both representations. |
@selfissued, why create another issue (this, #918) for one side of the discussion already framed to be held in #913? I'm going to keep my responses there, and I strongly suggest that #918 be closed as a duplicate of #913. |
What we need semanically is the cryptographic validity time of the VC, which is independent from the validity time of the underlying credential (claims). So 4 date/times are potentially needed. e.g. a degree claim is valid from the graduation date and does not expire. A UK driving license is valid from when the driver passes their driving test until the driver's age of 65. Multiple VCs with shorter cryptographic validity times could be issued during the claim lifetimes of both of these. |
I mostly agree with @David-Chadwick's latest comment, which was duplicated in #918 and #913, because #918 is really a duplicate of #913, and #918 is only serving to dilute, split, and/or replicate the discussion. I ask the chairs (tagging @brentzundel & @Sakurann) to make a determination of the duplication I assert, and I urge the chairs to close #918 in favor of #913, as #913 has substantially more discussion on the topic. (If the chairs prefer to raise this duplication as a question for the WG as a (participating) whole, I request that it be added to the agenda for August 31.) |
For what it's worth, it wasn't my intent to create a duplicate issue. I'd committed to Brent to file an issue on the topic and he encouraged me to do so. I tried to state the case for simplicity positively in the issue. I'm OK with continuing discussion in the other issue. |
I disagree with removing IssuanceDate and replacing it with ValidFrom. The time that a token was issued is normally included in it. For instance, that's for SAML and ID Tokens. It's true of current VCs.
Whereas, the ability to future/past date tokens is esoteric and will likely cause more problems than it solves. We should not introduce validFrom so that this remains impossible. That will help interoperability.
For context, the JWT
nbf
claim was copied from SAML'sNotBefore
for completeness, but it is essentially never used (except for JWT-VCs, where its inclusion was a mistake that we should fix in V2). (See w3c/vc-jose-cose#9 for an issue proposing that fix.)For context, https://www.w3.org/TR/2022/REC-vc-data-model-20220303/#issuance-date contains this note:
I believe this is moving us in the wrong direction - towards complexity and away from simplicity. Likewise, issue #913 , which in some ways is the dual of this issue, would also move us in the wrong direction - towards unnecessary complexity.
The text was updated successfully, but these errors were encountered: