-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller Documents #1307
Comments
We need to create the common Controller Document specification before any of the securing specifications go to CR. This is tracked in the securing specifications at w3c/vc-jose-cose#160 and w3c/vc-data-integrity#216. This needs to happen before CR because normative changes are needed to the Controller Document description in Data Integrity to enable it to be shared with VC-JOSE-COSE. We need to make these changes before CR so making them doesn't force us to inevitably have another round of CRs for both securing specifications. |
-1, we need to demonstrate that the definitions of controller documents in both vc-jose-cose and vc-data-integrity are going to converge before we can have a common specification. What you say below... @selfissued wrote:
...indicates that you intend to suggest breaking changes to vc-data-integrity, which would be objected to, and hold up both specifications for an unknown period of time. This would be unacceptable given the timeline of the WG. DI is ready to go into CR now and has multiple independent implementations. As we discussed on the last telecon, we can do this work in parallel and converge if there is a definite path to convergence. If there is true convergence, DI implementations will not need to change (and we won't need to go through a 2nd CR). If normative changes are necessary, they should be minor, and a 2nd CR is not a huge lift. |
The issue was discussed in a meeting on 2023-10-24 List of resolutions:
View the transcript1. Controller Documents.See github issue vc-data-model#1307. See github issue vc-data-integrity#216. See github pull request vc-data-integrity#219. Brent Zundel: Just for tracking purposes. Where we're at: DI and vc-jose-cose specify some sort of controller document.
Michael Jones: The goal here is to have a path forward for securing specs and controller docs.
Brent Zundel: Proposals build on one another. Let's get started. Manu Sporny: Looking at the proposals I can see controversy in 4, 5, 6, 7 and 8. Concerned with this being reopened before DI going into CR. Michael Jones: No intent to have preferences for a single securing spec. Orie Steele: Process question, is CR a thing the WG decides? Brent Zundel: The WG resolves to go to CR (which we've done for vc-json-schema, and others).
Manu Sporny: I'd change to "will attempt to". It might not be successful. Brent Zundel: I'll wordsmith this. Michael Jones: Feels like it's watered down. I would rather be on record on what we plan to do. Ok if we fail.
Manu Sporny: Needs to say something about timing on when the functionality will be removed.
Michael Jones: I've intentionally worded this so they're independent. Ted Thibodeau Jr.: Batch resolutions need to be handled as batch proposals. Doing it in the proposed order leaves significant holes. Brent Zundel: Wordsmithing all at once seems difficult, but we can attempt. Dave Longley: Thinking we need to include intent. Re: path forward - a sticking point is whether this delays CR. Manu Sporny: I made the concrete suggestion that we specify when the functionality will be removed (after controller document enters CR).
Michael Jones: Couldn't make last week call. Issue says it's a pre-CR issue. We should deal with it. Timing should be a separate proposal. Orie Steele: Seems like what we're saying is don't have anything delay DI getting into CR. Brent Zundel: Are you proposing we tackel #6? Manu Sporny: I think this is a bad idea. We've already went through the logic of not delaying CR in multiple calls.
Manu Sporny: All publications are aiming to be published on nov 7.
Manu Sporny: What we're seeing is that multiple changes are being asked (removing some pieces).
Manu Sporny: I think we shouldn't have that affect the DI timeline. If we succeed getting the controller document into CR, then we have created something common.
Manu Sporny: I'm not convinced we'll get the consensus. Blocking DI would delay publication even more.
Michael Jones: I think we should run the proposals. The editors of vc-jose-cose will appreciate understanding the intent.
Brent Zundel: The intent is to have 1.
Brent Zundel: Would anyone -1 this? If so, what changes would you like to see?
Brent Zundel: I think this would still possibly force a second CR. Ted Thibodeau Jr.: Not a -1. Concerned this doesn't say anything about when it's going to happen. Manu Sporny: The belief is that this modification would not cause a second CR for DI, because implementations would not have to change the way they're implemented. Paul Dietrich: Is this a merge, or just copying text? Ted Thibodeau Jr.: Have of my concern is that there might already be differences between docs. I don't know. Brent Zundel: The paths before us: 1) We copy paste (with slight modifications) from DI/vc-jose-cose to this doc. No changes to implementation in DI, not blocking.
Brent Zundel: Proposed resolution #3 is straigthforward. Let's do it. Manu Sporny: Question for selfissued, can we downscope them? I saw a proposal to remove content from them. That says we would be removing existing content. Michael Jones: The intent isn't to profile to remove stuff. The controller document is meant to have stuff in common. Manu Sporny: Controller documents are meant to have verification material. That's my concern, we're talking about gutting what controller documents are about.
Ted Thibodeau Jr.: Struggling not to feel ambushed by the proposals. Clearly there was thought put into it, but not all ramifications were thought through.
Brent Zundel: I believe in the positive intentions of both sides of this conversation. I don't think either side is trying to manipulate into some place of superiority. The intention is always to write the best spec. Michael Jones: If manu's primary concern is about the amount of work, i'll do it.
Manu Sporny: Not worried about doing the work, more about taking time off of other things.
Brent Zundel: Seems straighforward that we can make this work happen.
Joe Andrieu: Wanted to underscore what manu just said. Not about games. The way the proposal is structured would prefer Brent Zundel: We're nitpicking about the potential detail of a spec that hasn't been written.
Joe Andrieu: My concern is more about all the proposals together. I reserve the right to object depending on what happens with the specs.
|
The issue was discussed in a meeting on 2023-10-25 List of resolutions:
View the transcript2.1. Controller Documents (issue vc-data-model#1307)See github issue vc-data-model#1307. See github issue vc-data-integrity#216. See github pull request vc-data-integrity#219. Brent Zundel: We'll begin with the continuation of the topic of our special topic call, which was Controller Doc. Michael Jones: it makes sense to include that, it's a standards based key representation used in practice. Dave Longley: so, thinking about our call yesterday and the resolutions,.
Brent Zundel: just to repeat, we have one suggestion from Mike that .well-known be included. Dave Longley: yes, that's great. Dmitri Zagidulin: As a data point, about the .well-known mechanism, based on some recent VC implementations, there are a number of institutions like universities that are not allowed to create folders with dots in them. There are education institutions that can't put their keys in .well-known due to their web control panels and whatnot. It's useful, but not everyone can use it. Michael Jones: two responses.
Joe Andrieu: I'm not a fan of .well-known because it's anchored in a centralized resource/url. Brent Zundel: just to clarify, are you opposed to .well-known included at all, or to it being the /only/ mechanism. Joe Andrieu: at all.
Manu Sporny: I wanted to agree with what Dave was saying, and what Mike Jones just said. it would be fine to include a number of things in the controller doc, put them in a single document.
Manu Sporny: and when you go to profile, you can say "Do not use X or Y, we don't want you doing that" -- that's perfectly fine.
Manu Sporny: so, +1 to that. What that would mean is that we'd include 'publicKeyJWK', 'publicKeyMultibase', we'd include .well-known discovery mechanism.
Manu Sporny: so, +1 to that if it helps us move forward. Brent Zundel: I believe we have roughly a path forward.
Brent Zundel: here is draft proposal, anyone opposed? (and if yes, how should we change it). Joe Andrieu: I have some concerns re temporality. the controller document 'will include', which seems in the future? Brent Zundel: my understanding is - both DI and Jose/Cose would be written in the controller doc, as they're written today.
Brent Zundel: does that help with causality, Joe? Joe Andrieu: yes. Kristina Yasuda: it seems that this resolution does not apply to just key discovery, but other aspects as well. is the intent to just mix all the features from the securing specs? Manu Sporny: yes, my understanding as well. just to be crystal clear,.
Manu Sporny: the errors would move too.
Orie Steele: accurate. just in terms of current VC JOSE/COSE spec - it has already a profiled-down version, just needs to be able to refer to correct term definitions.
Brent Zundel: with that, we are ready to run the proposal.
Brent Zundel: if I'm understanding correctly, this single proposal captures all of the stuff from the remaining resolutions & proposals from yesterday.
Manu Sporny: agreed. Michael Jones: question to chairs (I'm open to many different answers) -- is it time to request volunteers to work on this new shared doc? Brent Zundel: If there are folks on the call who want to volunteer, I'd love to hear it. Michael Jones: I'll volunteer. Manu Sporny: I'll volunteer. Brent Zundel: solid editorial team. others are also welcome to volunteer now, or reach out to chairs. |
A Controller Document specification exists now: https://github.com/w3c/vc-controller-document Closing. |
There seems to be a need for a single definition of a controller document that can then be used by various VC securing specs (e.g., VC-DI and VC-JOSE-COSE).
This issue is for tracking the discussion and begins with the suggestion that the core data model makes the most sense as a "neutral" place for this definition that will require the least amount of additional effort.
The text was updated successfully, but these errors were encountered: