Add issue marker noting guidance about decoy values will be resolved in CR. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
npdoty,
dlongley,
jandrieu,
longpd,
iherman,
dmitrizagidulin,
TallTed,
David-Chadwick,
simoneonofri,
decentralgabe,
KDean-Dolphin and
brentzundel
This was referenced May 11, 2024
msporny
force-pushed
the
msporny-decoys-warning
branch
from
005736f
to
0073c2c
Compare
KDean-Dolphin
approved these changes
May 11, 2024
dlongley
approved these changes
May 11, 2024
David-Chadwick
approved these changes
May 11, 2024
iherman
approved these changes
May 12, 2024
npdoty
approved these changes
May 13, 2024
|
@npdoty wrote:
Great, thanks for the confirmation, @npdoty; we'll get this merged as soon as we can and include it in the CR-ready draft. In an attempt to parallelize the approvals we need, could you please convey that you are ok w/ proceeding to CR as long as the text in this PR is included: |
longpd
approved these changes
May 13, 2024
TallTed
approved these changes
May 13, 2024
mkhraisha
approved these changes
May 13, 2024
decentralgabe
approved these changes
May 13, 2024
brentzundel
approved these changes
May 13, 2024
|
The issue was discussed in a meeting on 2024-05-15
View the transcript3.1. Add issue marker noting guidance about decoy values will be resolved in CR. (pr vc-bitstring-status-list#171)See github pull request vc-bitstring-status-list#171. Manu Sporny: If we can merge this today, we can include it in the snapshot for publication.
Brent Zundel: You have approval to merge this after this call. |
|
Merging, as discussed on the call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to note that issue #150 will be addressed in CR, with more direct involvement by PING (and other concerned parties), by performing a more detailed analysis on decoy values.
Preview | Diff