Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify non-cancelable wheel events when there are no non-passive listeners #330

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 29, 2022

Fixes #282

This uses the same language as in https://w3c.github.io/touch-events/#cancelability

The following tasks have been completed:

Implementation commitment:

Copy link
Member

@garykac garykac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference to "mousewheel" seems out of place since it is not mentioned anywhere else in the specification.

If we want to include this, we should add mousewheel to Section 9 "Legacy Event Types" with the other deprecated event types. I've created an issue to track that: #331

@zcorpan
Copy link
Member Author

zcorpan commented Jun 29, 2022

I've removed mousewheel for this PR. It can be added back as part of fixing #331

@zcorpan zcorpan changed the title Specify non-cancelable wheel/mousewheel events when there are no non-passive listeners Specify non-cancelable wheel events when there are no non-passive listeners Jun 29, 2022
@garykac
Copy link
Member

garykac commented Jun 29, 2022

Thanks!

@garykac garykac merged commit 6e9966a into w3c:main Jun 29, 2022
github-actions bot added a commit that referenced this pull request Jun 29, 2022
SHA: 6e9966a
Reason: push, by @garykac

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zcorpan zcorpan deleted the fix-282 branch June 29, 2022 15:26
dontcallmedom pushed a commit to dontcallmedom/uievents that referenced this pull request Jul 1, 2022
SHA: 6e9966a
Reason: push, by @garykac

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the cancelability of wheel events
2 participants