Fix the section on 64bit systems #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwo
approved these changes
Nov 6, 2019
yurishkuro
reviewed
Nov 7, 2019
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
|
Thanks @SergeyKanzhelev. One question: there was a suggestion to move this information to a "non-normative" section. Is that where this is now? Sorry for my ignorance, but I assumed the file name would be changing. |
yurishkuro
reviewed
Nov 7, 2019
yurishkuro
reviewed
Nov 7, 2019
|
@yurishkuro Since there is such disagreement about which system should be required to upgrade or downgrade trace ids, perhaps it's better not to mention the system in this spec. I like the existing passive wording of |
justinfoote
reviewed
Nov 7, 2019
yurishkuro
approved these changes
Nov 7, 2019
justinfoote
approved these changes
Nov 7, 2019
|
Hi @bogdandrutu @adriancole @tylerbenson @jcchavezs @nicmunroe @reyang @danielkhan . There are no surprises in this PR. I believe it is reflecting overall agreement on how interoperability must work. If you have some time - please review. Thank you! |
reyang
reviewed
Nov 7, 2019
reyang
approved these changes
Nov 7, 2019
nicmunroe
approved these changes
Nov 7, 2019
yurishkuro
changed the title
tylerbenson
approved these changes
Nov 8, 2019
|
Thank you everybody for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
Fixes #337