Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.eslintrc.json): remove consistent-return #453

Merged
merged 5 commits into from
Jul 26, 2021

Conversation

marcoscaceres
Copy link
Member

Remove noisy rule... as our code show, there are valid cases for arrow functions that don't return anything.

Remove noisy rule... as our code show, there are valid cases for arrow functions that don't return anything.
Copy link
Contributor

@jennyliang220 jennyliang220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The airbnb code style is having "consistent-return":"error" for default. I don't have a strong opinion to change this rule. but if you were disabling it, the config should be:

"consistent-return":"off"

And the lint check should pass.

.eslintrc.json Outdated Show resolved Hide resolved
@jennyliang220 jennyliang220 merged commit 09fb29a into main Jul 26, 2021
@jennyliang220 jennyliang220 deleted the marcoscaceres-patch-1 branch July 26, 2021 04:07
@marcoscaceres
Copy link
Member Author

Thanks @jennyliang220!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants