Do not assign a default value to WakeLockRequestOptions.signal #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Web IDL, the following
WakeLockRequestOptions
instances in JavaScriptshould have the same effect (a dictionary that does not have the
signal
member present):
which are different from
which means a
WakeLockRequestOptions
dictionary with one member,signal
,whose value is
null
.Setting a default value to the nullable member
signal
means we'd alwayshave a
signal
member in the dictionary even when we do not set it atall (first 2 cases), which is not needed and does not make sense.
Preview | Diff