fix(linter-rules/no-http-props): ignore empty URIs (speced#3756)

w3c · Aug 24, 2021 · df17683 · df17683
1 parent 408df96
commit df17683
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/core/linter-rules/no-http-props.js b/src/core/linter-rules/no-http-props.js
@@ -33,7 +33,7 @@ export function run(conf) {
 
   const offendingMembers = Object.getOwnPropertyNames(conf)
     // this check is cheap, "prevED" is w3c exception.
-    .filter(key => key.endsWith("URI") || key === "prevED")
+    .filter(key => (key.endsWith("URI") && conf[key]) || key === "prevED")
     // this check is expensive, so separate step
     .filter(key =>
       new URL(conf[key], parent.location.href).href.startsWith("http://")

diff --git a/tests/unit/core/linter-rules/no-http-props-spec.js b/tests/unit/core/linter-rules/no-http-props-spec.js
@@ -11,8 +11,20 @@ describe("Core Linter Rule - 'no-http-props'", () => {
     );
   }
 
+  it("skips over defined, but empty, URIs", async () => {
+    const conf = {
+      undefined_URI: undefined,
+      empty_URI: "",
+      null_URI: null,
+      URI: "http://fail",
+    };
+    const warnings = await getWarnings(conf);
+    expect(warnings).toHaveSize(1);
+  });
+
   it("checks any prop ending with 'URI' (case sensitive)", async () => {
     const conf = {
+      undefined_URI: undefined,
       FAIL_uri: "http://fail",
       failURIfail: "http://fail",
       URI: "http://pass",