Drop dependency on chai for tests #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Chai testing library is now ECMAScript module only. This could have provided a good occasion to convert tests from CommonJS modules to ECMAScript modules, but then, looking into actual tests, many of them used Chai where they could just have used the basic Node.js `assert` module, and the few tests that used `expect` did not look more readable thanks to that syntax compared to a more basic `assert` approach. Instead of converting tes code to ECMAScript modules, this update rather drops the dependency on Chai, rewriting tests where needed to rather call regular `assert` functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chai testing library is now ECMAScript module only (see #1487). This could have provided a good occasion to convert tests from CommonJS modules to ECMAScript modules but then, looking into actual tests, many of them used Chai where they could just have used the basic Node.js
assertmodule, and the few tests that usedexpectdid not look more readable thanks to that syntax compared to a more basicassertapproach.Instead of converting test code to ECMAScript modules, this update rather drops the dependency on Chai, rewriting tests where needed to rather call regular
assertfunctions.