CSS extracts: Link entries back to spec anchor #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requested in w3c/webref#642 It was possible to link entries in CSS extracts back to entries in the dfns extract with a bit of logic but: 1. This requires having both CSS extracts and dfns extracts at hand, and the dfns extracts typically aren't included in the `@webref/idl` package. 2. This is somewhat error-prone. This updates the CSS definitions extraction logic to also extract the absolute URL (with fragment) of the definition whenever possible. A slight change of approach was needed as previous extraction logic handled "multi-definitions" (e.g., a table definition that defines multiple properties at once) through a text-based approach, and the code now also needs to track the IDs. Tests already contained IDs, so this update merely refreshes the expected results.
|
This seems to work surprisingly well in practice, in that all entries seem to end up with an
Important note: This adds a property to most entries in CSS extracts, which will invalidate the CSS patches in Webref. We'll have to re-generate them. Not too hard... but painful :/ |
dontcallmedom
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in w3c/webref#642
It was possible to link entries in CSS extracts back to entries in the dfns extract with a bit of logic but:
@webref/idlpackage.This updates the CSS definitions extraction logic to also extract the absolute URL (with fragment) of the definition whenever possible. A slight change of approach was needed as previous extraction logic handled "multi-definitions" (e.g., a table definition that defines multiple properties at once) through a text-based approach, and the code now also needs to track the IDs.
Tests already contained IDs, so this update merely refreshes the expected results.