Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json() should be defined in terms of Infra #381

Closed
annevk opened this issue Jul 9, 2024 · 0 comments · Fixed by #382
Closed

json() should be defined in terms of Infra #381

annevk opened this issue Jul 9, 2024 · 0 comments · Fixed by #382

Comments

@annevk
Copy link
Member

annevk commented Jul 9, 2024

It should use https://infra.spec.whatwg.org/#parse-json-bytes-to-a-javascript-value directly.
annevk added a commit that referenced this issue Jul 9, 2024
@annevk
Correct PushMessageData
531a7db 
Give PushMessageData a clear internal concept to hold the bytes and also make it clear that it cannot be null. None of the methods were prepared to handle it being null and nothing ever creates a PushMessageData object where it is null.

Partially addresses the concerns in #380 and fixes #381.
@annevk annevk mentioned this issue Jul 9, 2024
Merged
@annevk annevk closed this as completed in 8a6a92c Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct PushMessageData w3c/push-api
1 participant
@annevk