-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforce rel requirements #144
Conversation
add rel checks; move structural propertes ahead of informative
mention alternate for additional covers; remove requirement for a unique property; update algorithm
Another slightly edge case (it is a matter of taste, really). It says now:
I wonder whether it is not more logical to say that the 'cover' is set to true if that stuff is there and it is valid. The algorithm, as it stands now, will flag a cover page as existing even if it is not valid even if there is another one down the line that is perfectly valid. (I do not feel strong about this...) |
Sync to [PR #144](w3c/pub-manifest#144)
I'm hesitant about this, as they're only warnings. If they were stronger requirements than "should", maybe, but otherwise we're sort of ignoring that you're not supposed to list these twice and that we give precedence to the first one found. And what if you don't find one better specified, do you have to go back to the first, or is there a formula for which is best of not perfect options? End of the day it's an authoring mistake to have two covers as two separate resources, and incomplete information is one of the things that can go wrong. Better to warn the author and have them correct it than the user agent spend time trying to solve this, IMO. |
s/type/rel/
This PR makes the following changes:
But I think this needs more work as described in #143.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Nov 3, 2019, 10:44 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.