Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monkey patch sections #191

Open
Tracked by #219
npm1 opened this issue Aug 13, 2020 · 5 comments
Open
Tracked by #219

Remove monkey patch sections #191

npm1 opened this issue Aug 13, 2020 · 5 comments

Comments

@npm1
Copy link

npm1 commented Aug 13, 2020

There are 3 sections that monkey patch other specifications (the ones with name starting with "Interaction with "). The affected specs should probably be updated instead, and those sections should be removed.

@chrisn
Copy link
Member

chrisn commented Jun 22, 2023

Thanks for raising this, and apologies for taking so long to respond. I'm noting the TAG guidance, so looking at each of those sections:

  • Interaction with Fullscreen - It could well make sense to add to the Fullscreen spec.

  • Interaction with Remote Playback - This seems informative, so could be added to the Note after local playback device, e.g:

    NOTE: A local playback device might have extra outputs, like an external display or speakers/headphones, or a Picture-in-Picture window.

  • Interaction with Media Session - I'm not sure what this section is saying. The only thing I see in Media Session is the change proposed in Add enterpictureinpicture action mediasession#295. Do we need this section at all?

  • Interaction with Page Visibility - The first paragraph should probably remain in this spec as it's about the PiP window itself. The second paragraph, on system visibility state of a traversable navigable, could be added to the Page Visibility section in HTML.

@beaufortfrancois, @jernoble, what do you think?

@chrisn
Copy link
Member

chrisn commented Sep 15, 2023

Discussed "Interaction with Remote Playback" in the Second Screen WG meeting at TPAC. The group agreed to move this text to the Remote Playback API spec, but will need discussion if it needs to be normative.

@markafoltz
Copy link
Contributor

To clarify: Second Screen expects someone working on the PiP spec to open a PR against the Remote Playback API.

@chrisn
Copy link
Member

chrisn commented Mar 21, 2024

Regarding Interaction with Page Visibility, #223 partially addresses this, but would leave this text remaining:

The Picture-in-Picture window visibility MUST NOT be taken into account by the user agent to determine if the system visibility state of a traversable navigable has changed.

@beaufortfrancois and @marcoscaceres Any thoughts on what to do with this? Should it remain somewhere in this spec, or could be added to the Page Visibility section in HTML?

@beaufortfrancois
Copy link
Collaborator

I'd hope we could add this part to the HTML Page Visibility spec now that PiP has been implemented by two different implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants