Allow additional discovery mechanisms. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidSchinazi here's some updated language about DNS-SD usage for OSP. |
louaybassbouss
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Thanks @mfoltzgoogle for this PR LGTM also changes proposed by @DavidSchinazi
|
Sorry for the long turnaround time @DavidSchinazi. I finally got around to addressing your last review comments. The group agreed this was good to merge with your comments addressed; if you have any additional feedback feel free to append to the issue. |
github-actions bot
added a commit
that referenced
this pull request
Oct 27, 2021
SHA: 7305111 Reason: push, by @mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #273: [mDNS] OpenScreenProtocol should not restrict DNS-SD to mDNS
This makes it explicit that while DNS-SD over mDNS is mandatory to implement, the rest of the protocol doesn't rely on mDNS being the only way for agents to discover one another, and they can query DNS-SD over unicast DNS.
Note that we may need to adjust the
atmechanism intended to restrict connection attempts to intra-LAN scenarios. Would like to look at that in a separate issue.Preview | Diff