Prevent remove-a-track to recurse. #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this "Remove" a link to the algorithm was making the algorithm loop endlessly. Here we're not calling that algorithm again, we're just using the track set's remove method (from infra: https://infra.spec.whatwg.org/#list-remove).
|
dontcallmedom marked as non substantive for IPR from ash-nazg. |
alvestrand
approved these changes
Dec 3, 2024
dontcallmedom
approved these changes
Dec 3, 2024
This makes it clear that we deal with the set instead of the current algorithm. Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
henbos
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remove-a-track algorithm currently uses a link to itself in its step 2, making it an endless loop.
Here we're not calling that algorithm again, we're just using the track set's remove method (from infra: https://infra.spec.whatwg.org/#list-remove).
(Ps: [editorial] and [non-substantive])
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Dec 3, 2024, 8:10 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.