Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict handle getter visibility to dedicated worker #317

Commits on Sep 20, 2022

  1. Restrict handle getter visibility to dedicated worker

    Removes the MediaSource handle attribute visibility from the main Window
    context, leaving it visible only in dedicated worker contexts. Also
    removes the conditional throwing of NotSupportedError exceptions on
    getting this attribute's value if the implementation doesn't support
    that.
    
    Overall, this change is to undo the backwards incompatibility issue
    found when older versions of MSE web app libraries enumerated main
    thread MediaSource attribute values, hitting exception in the Chromium
    feature implementation through milestone 107. This change replaces that
    with simpler and safer visibility restriction of this getter to just the
    context where it must be supported if the implementation supports
    MSE-in-Workers.
    
    Note, this change replaces the alternative fix discussed in
    w3c/media-source PR w3c#316.
    wolenetz committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    84755e5 View commit details
    Browse the repository at this point in the history