Simplify text for many conditional cross-context operations #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following one of the suggested alternatives by @mwatson2 on previous pull request review [1], this change introduces a "mirror if necessary" algorithm and uses it to simplfiy multiple places in the spec text where the attached MediaSource needs to update the state of the attached HTMLMediaElement. Note, there are several other cross-context pieces of text left unchanged, since they are specific to either setting up the conditionally cross-context communication ports, conditionally tearing them down, or describe how the extended media element buffering or seekable attributes behave relative to the potentially cross-context and asynchronous communication of the state used in those extensions. Note, upcoming PR for privacy and security section addition will also update (restrict) the flexibility for optimizing cross-context communication to help mitigate related timing attacks in implementations. [1] w3c#282 (review)
|
@mwatson2 - please take a look. Thanks! |
|
@mwatson2 please review. Thank you! |
mwatson2
approved these changes
Mar 14, 2022
wolenetz
deleted the
address_mwatson2_comments_on_initial_mseiw_draft_spec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following one of the suggested alternatives by @mwatson2 on previous
pull request review [1], this change introduces a "mirror if necessary"
algorithm and uses it to simplfiy multiple places in the spec text where
the attached MediaSource needs to update the state of the attached
HTMLMediaElement. Note, there are several other cross-context pieces of
text left unchanged, since they are specific to either setting up the
conditionally cross-context communication ports, conditionally tearing
them down, or describe how the extended media element buffering or
seekable attributes behave relative to the potentially cross-context and
asynchronous communication of the state used in those extensions.
Note, upcoming PR for privacy and security section addition will also
update (restrict) the flexibility for optimizing cross-context
communication to help mitigate related timing attacks in
implementations.
[1] #282 (review)
Preview | Diff