Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: remove serviceworker member #825

Merged
merged 1 commit into from
Nov 15, 2019
Merged

BREAKING CHANGE: remove serviceworker member #825

merged 1 commit into from
Nov 15, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Nov 12, 2019 •
edited by pr-preview bot
Loading

Closes #800

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox (link to issue)
  • Edge (public signal)

Commit message:

Removing, as no one implemented the serviceworker member.

Preview | Diff

@marcoscaceres marcoscaceres requested a review from mgiuca November 12, 2019 09:03
mgiuca
mgiuca approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@mgiuca mgiuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pour one out for serviceworker.

@marcoscaceres marcoscaceres merged commit 8923ba4 into gh-pages Nov 15, 2019
@marcoscaceres marcoscaceres deleted the remove_serviceworker branch November 15, 2019 07:09
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Jan 31, 2020
@sideshowbarker
Deprecate Web App Manifest serviceworker member
9f5b932 
w3c/manifest#825 removed the serviceworker
member from the set of possible Web App Manifest members.

w3c/manifest@8923ba4
@sideshowbarker sideshowbarker mentioned this pull request Jan 31, 2020
Merged
queengooborg pushed a commit to mdn/browser-compat-data that referenced this pull request Jan 31, 2020
@sideshowbarker
Deprecate Web App Manifest serviceworker member (#5627)
2ede599 
w3c/manifest#825 removed the serviceworker
member from the set of possible Web App Manifest members.

w3c/manifest@8923ba4
@marcoscaceres marcoscaceres mentioned this pull request Apr 2, 2020
Closed
@benfrancis benfrancis mentioned this pull request Apr 3, 2020
Closed
@mgiuca mgiuca mentioned this pull request May 8, 2020
Open
christianliebel pushed a commit to christianliebel/manifest that referenced this pull request May 27, 2020
@christianliebel
BREAKING CHANGE: remove serviceworker member (w3c#825)
f13b156
@marcoscaceres marcoscaceres mentioned this pull request Oct 19, 2020
Closed
@coderfin coderfin mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiuca mgiuca mgiuca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify ServiceWorkerRegistrationObject’s purpose
2 participants
@marcoscaceres @mgiuca