Minor editorial cleanup / refactor of Manifest processing steps #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Jan 23, 2023
Directly process name, short_name, theme_color and background_color. (Note: short_name was redundantly processed in the following step. We could have just removed that step, but I think it is more readable to just remove the for loop.)
mgiuca
force-pushed
the
processing-editorial
branch
from
282d2aa to
aa2a052
Compare
|
I'm getting a host error connecting to labs.w3.org which is blocking the merge (I think it was ready to merge before but I rebased over #1067). |
|
I'm also getting a Respec error:
But it isn't caused by this PR. |
mgiuca
force-pushed
the
processing-editorial
branch
from
aa2a052 to
a1b2b54
Compare
|
@marcoscaceres Something is broken at the manifest factory. Every build is failing with what looks like network errors since Friday. https://github.com/w3c/manifest/actions/workflows/auto-publish.yml The failures all start with "[ERROR] Network error loading highlighter". Then as of this morning a new failure was added: "ROR] Plugin w3c/group took too long.". |
This keeps the relevant info about the default values of members closely related to the other relevant material about that member. It's also consistent with how the rest of the members (e.g. scope) treat default values. And prevents possible errors where the incorrect default value is used by an intermediate step in between assigning the default and assigning the actual value.
mgiuca
force-pushed
the
processing-editorial
branch
from
a1b2b54 to
d720167
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 25, 2023
SHA: 80310d0 Reason: push, by mgiuca Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (choose at least one, delete ones that don't apply):
Commit message:
Minor editorial cleanup / refactor of Manifest processing steps.
Pre-work for #668.
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff