Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of sourceCharPosition attribute, and amend explainer #137

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix type of sourceCharPosition attribute, and amend explainer #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ The {{PerformanceLongAnimationFrameTiming/scripts}} attribute's getter steps are
readonly attribute DOMHighResTimeStamp executionStart;
readonly attribute DOMString sourceURL;
readonly attribute DOMString sourceFunctionName;
readonly attribute DOMString sourceCharPosition;
readonly attribute long long sourceCharPosition;
readonly attribute DOMHighResTimeStamp pauseDuration;
readonly attribute DOMHighResTimeStamp forcedStyleAndLayoutDuration;
readonly attribute Window? window;
Expand Down
4 changes: 3 additions & 1 deletion loaf-explainer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ const someLongAnimationFrameEntry = {

// In the case of promise resolver this would be the invoker's source location
// Note that we expose character position rather than line/column to avoid overhead of line splitting.
sourceLocation: "functionName@URL:characterPosition",
sourceURL: "https://example.com/big.js",
sourceFunctionName: "do_something_long",
sourceCharPosition: 10,

// Relationship between the (same-origin) window where this script was executed and
// this window.
Expand Down
Loading