Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial issues #130

Merged
merged 27 commits into from
Feb 15, 2019
Merged

Editorial issues #130

merged 27 commits into from
Feb 15, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 13, 2019

For #124 and #127.


Preview | Diff

@gkellogg gkellogg force-pushed the issue-124-editorial-issues branch from 73cb7f4 to ba3af21 Compare February 13, 2019 18:45
…dded contexts. Remove confusing language about compaction, which is not particularly important here.

Note, examples aren't _active_ as others, as the aside mechanism is incompatible with our other tabbed examples.
@gkellogg
Copy link
Member Author

Thus far, this PR addresses comments in #124, although some changes are not made, as indicated in #124 (comment) and #124 (comment).

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
- "an" that should be "a"
- missing <code> tag around `@graph`
- missing "to"
@iherman
Copy link
Member

iherman commented Feb 14, 2019

Looking at the new section before the (new) example 19, shouldn't it be "...with a @graph property can be useful for saving the repetition of @context"? (The current sentence repeats @graph on both places.)

@iherman iherman mentioned this pull request Feb 14, 2019
13 tasks
@iherman
Copy link
Member

iherman commented Feb 14, 2019

See also #127 (comment)

@gkellogg gkellogg changed the title [WIP] Editorial issues Editorial issues Feb 15, 2019
@gkellogg gkellogg requested a review from iherman February 15, 2019 01:25
@gkellogg gkellogg self-assigned this Feb 15, 2019
@gkellogg
Copy link
Member Author

Should be ready to go now.

@gkellogg gkellogg merged commit b696e4c into master Feb 15, 2019
@gkellogg gkellogg deleted the issue-124-editorial-issues branch February 15, 2019 17:01
@gkellogg gkellogg mentioned this pull request Feb 16, 2019
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants