Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default for extractAllScripts in toRdf() should be true. #606

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jul 10, 2024

Tests are already consistent with this interpretation, although it was never documented in the API properly.

Fixes #603.


Preview | Diff

index.html Outdated Show resolved Hide resolved
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@BigBlueHat
Copy link
Member

@pchampin this is pending your review, fwiw.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@gkellogg gkellogg merged commit 45d172b into main Jul 26, 2024
3 checks passed
@gkellogg gkellogg deleted the default-extractAllScripts branch July 26, 2024 16:44
@BigBlueHat BigBlueHat added the class-3 Class-3 change label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toRdf() and flatten() API require extractAllScripts to default to true
6 participants