Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The propagate option to Create Term Definition is unused. #233

Closed
gkellogg opened this issue Dec 3, 2019 · 1 comment · Fixed by #236
Closed

The propagate option to Create Term Definition is unused. #233

gkellogg opened this issue Dec 3, 2019 · 1 comment · Fixed by #236

Comments

@gkellogg
Copy link
Member

gkellogg commented Dec 3, 2019

It was used previously, but has since been made redundant, the algorithm signature can be simplified.

@iherman
Copy link
Member

iherman commented Dec 6, 2019

This issue was discussed in a meeting.

  • RESOLVED: Any changes to algorithm text that do not affect the result of the algorithm may be considered non-normative changes.
View the transcript 4.1. The propagate option to Create Term Definition is unused.
Benjamin Young: #233
Benjamin Young: first issue is this one …
… Propagate option is unused in the create term definition.
Gregg Kellogg: At one time, we passed propagate from context parsing to create term definition. Subsequently we reverted that, so now if you look at the API document, in create term definition, if you click that argument, you’ll see it’s not anywhere in the algorithm
… I noticed this in the jsonld.js algorithm. Verified in my own implementation
… so we can simplify it by taking this argument out
Dave Longley: +1 to remove it and simplify (it doesn’t actually change anything!)
Gregg Kellogg: question is … is that a normative change?
… no processing has changed, just the requirements for calling
… sure that we’ll face other similar things after publication
Ivan Herman: That means I think that the algorithm doesn’t change, it just has an unnecessary parameter
Gregg Kellogg: Yes, you’re passing an argument that is never used
Ivan Herman: So if I remove it, then no change … but it’s definitely borderline
Dave Longley: in no way would the output of the algorithm change, which is what is normatively defined
Gregg Kellogg: Yes, that would also speak to making changes to the algorithms in the future … the results can’t change
Dave Longley: I think this would be a useful precedent to set
Gregg Kellogg: Sense of the WG is that minor changes to the text in algorithms that do not affect the results, as specified, may be considered editorial changes
Proposed resolution: Any changes to algorithm text that do not affect the result of the algorithm may be considered non-normative changes. (Dave Longley)
Rob Sanderson: +1
Gregg Kellogg: +1
Dave Longley: +1
Ivan Herman: +1
Ruben Taelman: +1
Benjamin Young: +1
Tim Cole: +1
Harold Solbrig: +1
David I. Lehn: +1
Gregg Kellogg: +1
Resolution #3: Any changes to algorithm text that do not affect the result of the algorithm may be considered non-normative changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants