-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow gridcell and treeitem roles on button elements #298
Comments
Closing. Reasoning provided in the closed PR #299 |
@scottaohara would you mind reopening, since we discussed taking a look at this again? |
closes #444 closes #395 closes #298 This PR makes the allowances for button-elements (button, input type=button|image|submit|reset) more consistent with each other. Additionally, slider and gridcell are now listed under the allowed roles for these elements. the LOE to properly create the necessary UX for some of these roles when specified, especially on the `input` type buttons, is rather large _but_ possible. Any failures to not implement these properly would be caught by WCAG rules. Allowing the roles won't change that.
re: discussion mentioned above - the reason this was re-opened is because while HTML's content model will still disallow nested interactive elements within a button element (regardless if its role was overwritten or not), in further testing there does not appear to be any negative impact from a UX pov. Additionally, even in situations where using a base button element for these roles, or if one were to include nested interactive elements - any problems found would either be issues for all users (e.g., pressing a gridcell submits a form unexpectedly) or would likely be found via other wcag related testing (automated or manual). |
In the Rules of ARIA attribute usage by HTML element ,
<button>
already allows every child role of composite widgets that manage focus except for tree and grid.There are benefits in using
<button>
as a base of interaction in these widgets, such as:Those benefits also apply to
gridcell
s andtreeitem
s, so it seems like it would be valuable to add those as well.Happy to do a PR for this :)
The text was updated successfully, but these errors were encountered: