Add [SecureContext] tags to the interfaces
#142
Conversation
There was a problem hiding this comment.
I'm approving this change, but I'll note that because historically this feature used to be available in non-secure contexts implementations have not yet completely adopted using [SecureContext] because they have fallback/flag code which can enable this API in non-secure contexts in some circumstances.
There was a problem hiding this comment.
Actually, I think I'm going to have to reject these changes because it appears that for this API these is implementation consensus on a non-standard handling of secure context requirements. This used to be specified in the steps for getCurrentPosition() and watchPosition() (see #34) but this text got dropped in later revisions to this specification.
All major engines do not include a [SecureContext] requirement on the navigator.geolocation attribute:
- Gecko: https://searchfox.org/mozilla-central/source/dom/webidl/Navigator.webidl#136
- WebKit: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/geolocation/Navigator%2BGeolocation.idl
- Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/geolocation/navigator_geolocation.idl
To properly match this specification to the implementations the language invoking the error callback with a "permission denied" error needs to be restored.
w3c/webrefrepo automatically extracts syntaxes from these spec docs. At the moment some syntax sections are missing the[SecureContext]tags so it is missing from extracted data in webref as well.The feature has been marked available in secure context in MDN docs.
The PR adds the tags to the remaining interfaces.
💥 Error: 502 Bad Gateway 💥
PR Preview failed to build. (Last tried on Feb 5, 2024, 2:20 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.