Add [SecureContext] tags to the interfaces
#192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,6 +361,7 @@ <h2> | |||
| the main <a href="https://w3c.github.io/gamepad/">Gamepad spec</a>. | |||
| </p> | |||
| <pre class="idl"> | |||
| [SecureContext] | |||
There was a problem hiding this comment.
I don't think this is valid... it's a partial interface.
| @@ -361,6 +361,7 @@ <h2> | |||
| the main <a href="https://w3c.github.io/gamepad/">Gamepad spec</a>. | |||
| </p> | |||
| <pre class="idl"> | |||
| [SecureContext] | |||
There was a problem hiding this comment.
Suggested change
| [SecureContext] |
| @@ -1526,7 +1526,7 @@ <h2> | |||
| <pre class="idl"> | |||
| [Exposed=Window] | |||
| partial interface Navigator { | |||
| sequence<Gamepad?> getGamepads(); | |||
| [SecureContext] sequence<Gamepad?> getGamepads(); | |||
There was a problem hiding this comment.
This wouldn't be web compatible. See #113.
| @@ -1526,7 +1526,7 @@ <h2> | |||
| <pre class="idl"> | |||
| [Exposed=Window] | |||
| partial interface Navigator { | |||
| sequence<Gamepad?> getGamepads(); | |||
| [SecureContext] sequence<Gamepad?> getGamepads(); | |||
There was a problem hiding this comment.
Suggested change
| [SecureContext] sequence<Gamepad?> getGamepads(); | |
| sequence<Gamepad?> getGamepads(); |
| @@ -1071,7 +1071,7 @@ <h2> | |||
| feedback. | |||
| </p> | |||
| <pre class="idl"> | |||
| [Exposed=Window] | |||
| [Exposed=Window, SecureContext] | |||
There was a problem hiding this comment.
Not sure this one makes sense either, to be honest. Half of the API is exposed in a regular context, and taking this interface away would probably break things.
marcoscaceres
requested changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w3c/webrefrepo automatically extracts syntaxes from these spec docs. At the moment some syntax sections are missing the[SecureContext]tags so it is missing from extracted data in webref as well.The feature has been marked available in secure context in MDN docs.
The PR adds the tags to the remaining interfaces.
💥 Error: 502 Bad Gateway 💥
PR Preview failed to build. (Last tried on Feb 5, 2024, 2:46 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.