Refactored "run" and "processEpubFile" file methods #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeltour
added
type: improvement
rdeltour
force-pushed
the
main-cleanup
branch
from
4f8dfdf to
2a7dbea
Compare
- Make `run` and `processEpubFile` methods run the same code to ensure consistent behavior. - Remove several duplicate or unused methods. - Rework `processArguments` method to use regular expressions and a switch statement.
rdeltour
force-pushed
the
main-cleanup
branch
from
2a7dbea to
3ed77fe
Compare
rdeltour
added
status: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored "run" and "processEpubFile" file methods to actually run the same code to ensure consistent behavior.
Also removed several duplicate or unused methods.
Reworked "processArguments" method to use regular expressions and a switch statement.