Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider HTML form elements as scripted content #1419

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented Dec 2, 2022

Fixes #1282

@rdeltour rdeltour added this to the v5.0.0-beta milestone Dec 2, 2022
@rdeltour rdeltour requested a review from mattgarrish December 2, 2022 15:14
@rdeltour rdeltour self-assigned this Dec 2, 2022
Copy link
Member

@mattgarrish mattgarrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is alright as it is, but I think the interpretation of "forms" in the specification is meant to be broader. Reading systems don't have to support any form elements, so it includes input, button, etc. outside of a form element. But the spec isn't very clear in its wording. I'm going to open an issue to clarify.

@mattgarrish
Copy link
Member

Scratch what I said above. After digging around through some old issues this is fine. I've opened w3c/epub-specs#2497 to clarify the ambiguity in the spec, though.

Base automatically changed from test/url-idn to release/v5.0.0 December 6, 2022 14:40
@rdeltour rdeltour merged commit 1bae7f7 into release/v5.0.0 Dec 6, 2022
@rdeltour rdeltour deleted the fix/html-form-is-scripted branch December 6, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants