Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-animations-1] Animations are only canceled if base and computed display are none. #8713

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

flackr
Copy link
Contributor

@flackr flackr commented Apr 13, 2023

See #6429

@flackr flackr requested a review from fantasai April 13, 2023 21:12
@flackr
Copy link
Contributor Author

flackr commented Apr 13, 2023

This is a rough attempt at specifying the proposed behavior in #6429. Perhaps it should be part of the deltas in css-animations-2?

@fantasai
Copy link
Collaborator

fantasai commented Apr 14, 2023

Yeah, I think it should go into css-animations-2. display isn't animatable in L1.

@flackr
Copy link
Contributor Author

flackr commented Apr 18, 2023

Yeah, I think it should go into css-animations-2. display isn't animatable in L1.

Done. This also fits better as animations are canceled / started by the display of their owning element - a concept which is more fleshed out in css-animations-2.

@flackr flackr merged commit d35cf94 into w3c:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants