[css-view-transitions-1] Rename starting function and add callback instead of opts dict #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
css-view-transitions-1/Overview.bs
Outdated
| @@ -747,7 +743,7 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi | |||
|
|
|||
| Note: This happens if |transition| was [=skip the page transition|skipped=] before this point. | |||
|
|
|||
| 1. [=Call the DOM update callback=] of |transition|. | |||
| 1. If it is not null, [=Call the DOM update callback=] of |transition|. Otherwise, treat |transition|'s [=ViewTransition/DOM updated promise] in subsequent steps as resolved. | |||
There was a problem hiding this comment.
Could you update the text here: https://drafts.csswg.org/css-view-transitions-1/#call-the-dom-update-callback to resolve the DOM updated promise if the callback is null.
css-view-transitions-1/Overview.bs
Outdated
| @@ -834,7 +830,7 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi | |||
|
|
|||
| 1. [=Assert=]: |transition|'s [=ViewTransition/phase=] is not "`done`". | |||
|
|
|||
| 1. If |transition|'s [=ViewTransition/phase=] is [=phases/before=] "`dom-update-callback-called`", then [=call the DOM update callback=] of |transition|. | |||
| 1. If |transition|'s [=ViewTransition/phase=] is [=phases/before=] "`dom-update-callback-called`", then [=call the DOM update callback=] of |transition| if it is not null. | |||
There was a problem hiding this comment.
Won't need this to change either then.
|
PTAL |
khushalsagar
reviewed
Nov 3, 2022
Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
khushalsagar
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback instead of dictionary: #7827 (resolved by editor's discretion)
Rename starting function to startViewTransition: #7788 (resolved by CSSWG consensus)