Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cssom] Don't serialize a shorthand if there are longhands with other property group / mapping logic in between the longhands of that shorthand. #5655

Merged
merged 3 commits into from
Oct 23, 2020
Merged

[cssom] Don't serialize a shorthand if there are longhands with other property group / mapping logic in between the longhands of that shorthand. #5655

merged 3 commits into from
Oct 23, 2020

Commits on Oct 23, 2020

  1. [cssom] Reduce by one the level of indentation of the "serialize a CS… 

    …S declaration block" algo.

By moving `longhands` into the loop we can also avoid removing from it
dynamically when serializing a given shorthand.
    @emilio
    emilio committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    5854419 View commit details
    Browse the repository at this point in the history

  2. [cssom] Minor tweak. 

    Once you've serialized one shorthand that contains `property`, you can
skip to the declaration loop, as the rest of the iterations of
`shorthand loop` are useless.
    @emilio
    emilio committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    763ee31 View commit details
    Browse the repository at this point in the history

  3. [cssom] Don't serialize a shorthand if there are longhands with other… 

    … property group / mapping logic in between the longhands of that shorthand.

Per #3030.
    @emilio
    emilio committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    d79046a View commit details
    Browse the repository at this point in the history