Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-mediaqueries] Should prefers-color-scheme in iframes be context-dependent? #7493

Open
emilio opened this issue Jul 13, 2022 · 2 comments

Comments

@emilio
Copy link
Collaborator

emilio commented Jul 13, 2022

This is a follow-up for #7213.

It seems in that issue, we were in general agreement that doing this for images and maybe even same-origin <iframe>s would be ok, but @tabatkins and @smfr mentioned that cross-origin frames might not be ok, and I'm curious about the reasoning for that, since other similar alterations like #4772 have no same-origin restrictions. When I talked about this with the security folks at Mozilla, there didn't seem to be a particularly interesting attack vector here.

This would be useful both for consistency, but also because it would allow use cases like #7213 (comment) to work. Otherwise, there's no way to have a transparent iframe without coordination with the embedder page, even if the embedded page could support both light and dark color schemes.

cc @smfr, @chrishtr, @lilles, @tabatkins

@chrishtr
Copy link
Contributor

If there are no useful attack vectors then I agree it should also be context-dependent in cross-origin iframes.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed prefers-color-scheme and iframes, and agreed to the following:

  • RESOLVED: Context-dependent color scheme propagation works for iframes (including cross-origin) unless specifically restricted
The full IRC log of that discussion <fantasai> Subtopic: prefers-color-scheme and iframes
<bramus> @florian I will keep on tweaking … had already done so a bit
<TabAtkins> github: https://github.com//issues/7493
<fantasai> astearns: Should prefers-color-scheme in iframes be context-dependent?
<fantasai> TabAtkins: yes
<fantasai> TabAtkins: proposed resolution is that we propagate used color scheme to embedded documents, regardless of cross-origin status, by default
<florian> s/@florian I will keep on tweaking … had already done so a bit//
<fantasai> emilio: not used color scheme exactly, like before
<fantasai> TabAtkins: however we define propagation, we do the same for iframes
<fantasai> dholbert: Is there a term for the actually used color scheme?
<fantasai> TabAtkins: the actually rendered one is the "used color scheme"
<fantasai> emilio: but that's not what we want to propagate
<TabAtkins> TabAtkins: not quite in all cases - see preivou sissue
<fantasai> emilio: in the case of a page that doesn't specify a color scheme, we *use* light, but the preference is context-dependent and could be dark
<fantasai> astearns: So the thing we resolved on in the last issue, happens in all embedding contexts
<fantasai> TabAtkins: unless otherwise specified
<fantasai> TabAtkins: there are some embedding context we will restrict this
<fantasai> astearns: objections?
<fantasai> RESOLVED: Context-dependent color scheme propagation works for iframes (including cross-origin) unless specifically restricted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants