Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-suite errors #2194

Closed
tobireif opened this issue Jan 17, 2018 · 9 comments · Fixed by web-platform-tests/wpt#9071
Closed

Test-suite errors #2194

tobireif opened this issue Jan 17, 2018 · 9 comments · Fixed by web-platform-tests/wpt#9071

Comments

@tobireif
Copy link

Filing this here because time doesn't allow me to be subscribed to public-css-testsuite@w3.org .

Screenshots:

screenshot_1

screenshot_2

screenshot_3

@tobireif
Copy link
Author

(click on each image for the larger view)

@fantasai
Copy link
Collaborator

Just, to look at the mailing list issue for a moment--to subscribe (this is not super obvious) to public-css-testsuite@w3.org you have to send a mail with the subject “subscribe” to the address public-css-testsuite-request@w3.org. If you did that and it didn't work, let me know: we need to fix that.

But filing here is fine. @plinss is in charge of the harness, though, so I can't help you with fixing the actual problem. :)

@plinss
Copy link
Member

plinss commented Jan 17, 2018

The base problem is with the style-change.js file, it needs to be in a support directory that is in the same directory as the test, so the script tag should have a src="support/style-change.js" rather than "../support/style-change.js".

This is a known limitation of the build system, as the directory structure of the test suite gets flattened.

I do need to update the "Report Issue" button to no longer point to Shepherd

mrego added a commit to mrego/wpt that referenced this issue Jan 17, 2018
This should fix w3c/csswg-drafts#2194 as it's moving the style-change.js script
under css/css-grid/alignment/support/ folder.

On top of that it's fixing those tests as the second checkLayout() call
was never checked.
This was because by default checkLayout() calls done(), and the test thinks
it has already finished.
Modified the call to checkLayout() in the script style-change.js
and calling manually done() in the tests fixes the problem.
@tobireif
Copy link
Author

One other error in the Chrome console: eg at
http://test.csswg.org/harness/test/css-grid-1_dev/grid-alignment-implies-size-change-001/ :
"The Content Security Policy 'default-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' 'nonce-wDymwtEQWUymGrW8KxZ5lcZqWCJOESCFh01rH3IckHg='; frame-ancestors 'none';' was delivered in report-only mode, but does not specify a 'report-uri'; the policy will have no effect. Please either add a 'report-uri' directive, or deliver the policy via the 'Content-Security-Policy' header."

@tobireif
Copy link
Author

tobireif commented Jan 18, 2018

Thanks for looking into / fixing these issues!

Another one: eg at http://test.csswg.org/harness/test/css-grid-1_dev/grid-alignment-implies-size-change-011/ :
"Failed to load resource: the server responded with a status of 404 (Not Found)" "100x100-green.png"
/
"GET http://test.csswg.org/suites/css-grid-1_dev/nightly-unstable/grid-items/support/100x100-green.png 404 (Not Found)"

mrego added a commit to mrego/wpt that referenced this issue Jan 18, 2018
More issues detected on w3c/csswg-drafts#2194.
This time it's fixing the relative path to an image.
The patch copies the 100x100-green.png file under the relative support/ folder
and modifies the paths to it in the tests.
@mrego
Copy link
Member

mrego commented Jan 18, 2018

I've fixed the issue with the image, it was again a problem with the ../ paths.

Regarding the JavaScript console error I don't know what it's but I don't see it in http://w3c-test.org/css/css-grid/alignment/grid-alignment-implies-size-change-001.html

@tobireif
Copy link
Author

Thanks! The CSP error, in Chrome:

screenshot

@tobireif
Copy link
Author

The JS error at test.csswg.org/harness/test/css-grid-1_dev/grid-alignment-implies-size-change-019/ is gone (probably since the path to the .js got fixed).

@plinss
Copy link
Member

plinss commented Jan 18, 2018

The CSP error is the result of some experimental code in the framework that the harness is built on. It's set to report-only so doesn't affect the behavior of the browser. There's no report-uri because we don't need one yet (no point in reporting against an unfinished CSP policy). Chrome is just warning that the CSP heading isn't doing anything useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants