[cssom] Declaration block serialization treats shorthands strangely #1774

jdm · 2017-09-01T20:24:17Z

The shorthand loop when serializing a declaration block has two odd parts to it:

it refers to the longhands array which consists of properties that have not yet been serialized, but that array is only defined before the start of the loop. As written, it's not clear if step 1 of the shorthand loop is supposed to account for properties serialized in previous iterations of the shorthand loop.
it's also not clear why it's worth continuing to execute subsequent iterations of the shorthand loop if a shorthand is successfully serialized. Given that shorthands are organized in preferred order, why would we end up serializing a less-preferred shorthand if a more-preferred one was already used?

The text was updated successfully, but these errors were encountered:

Make serialization match Gecko in a few corner cases This addresses the testcases from https://bugzilla.mozilla.org/show_bug.cgi?id=1345218. Gecko differs from the specification by doing the following: * reusing longhands that have previously been serialized in order to serialize shorthands * immediately breaking out of the shorthand loop for the current property as soon as a shorthand is successfully serialized w3c/csswg-drafts#1774 is filed to track ways that the standard could be made more clear on these points. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [bug 1345218](https://bugzilla.mozilla.org/show_bug.cgi?id=1345218). - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18352)

…cases (from jdm:serialize-fun); r=emilio This addresses the testcases from https://bugzilla.mozilla.org/show_bug.cgi?id=1345218. Gecko differs from the specification by doing the following: * reusing longhands that have previously been serialized in order to serialize shorthands * immediately breaking out of the shorthand loop for the current property as soon as a shorthand is successfully serialized w3c/csswg-drafts#1774 is filed to track ways that the standard could be made more clear on these points. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [bug 1345218](https://bugzilla.mozilla.org/show_bug.cgi?id=1345218). - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: e50341d4a91beded42bdcdf37bfb8a7e53070234 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 7a6a5916d6c5fb63f277ceaad62cf83fe03d9705

…cases (from jdm:serialize-fun); r=emilio This addresses the testcases from https://bugzilla.mozilla.org/show_bug.cgi?id=1345218. Gecko differs from the specification by doing the following: * reusing longhands that have previously been serialized in order to serialize shorthands * immediately breaking out of the shorthand loop for the current property as soon as a shorthand is successfully serialized w3c/csswg-drafts#1774 is filed to track ways that the standard could be made more clear on these points. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [bug 1345218](https://bugzilla.mozilla.org/show_bug.cgi?id=1345218). - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: e50341d4a91beded42bdcdf37bfb8a7e53070234

…cases (from jdm:serialize-fun); r=emilio This addresses the testcases from https://bugzilla.mozilla.org/show_bug.cgi?id=1345218. Gecko differs from the specification by doing the following: * reusing longhands that have previously been serialized in order to serialize shorthands * immediately breaking out of the shorthand loop for the current property as soon as a shorthand is successfully serialized w3c/csswg-drafts#1774 is filed to track ways that the standard could be made more clear on these points. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [bug 1345218](https://bugzilla.mozilla.org/show_bug.cgi?id=1345218). - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: e50341d4a91beded42bdcdf37bfb8a7e53070234 UltraBlame original commit: db9ef4f3705b3a4541fef5093398ba43c110fc15

emilio · 2020-10-25T17:45:32Z

This was fixed in #5655, second commit in particular.

jdm mentioned this issue Sep 1, 2017

Make serialization match Gecko in a few corner cases servo/servo#18352

Merged

4 tasks

fantasai added the cssom-1 Current Work label Sep 5, 2017

emilio closed this as completed Oct 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cssom] Declaration block serialization treats shorthands strangely #1774

[cssom] Declaration block serialization treats shorthands strangely #1774

jdm commented Sep 1, 2017

emilio commented Oct 25, 2020

[cssom] Declaration block serialization treats shorthands strangely #1774

[cssom] Declaration block serialization treats shorthands strangely #1774

Comments

jdm commented Sep 1, 2017

emilio commented Oct 25, 2020