Handle module scripts that include top-level await. #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is in response to whatwg/html#4352. @domenic , I'm not sure if this is what we want in terms of behavior, but it's a change, at least :) |
domenic
requested changes
Apr 24, 2020
| 6. Run the <a>responsible event loop</a> specified by |insideSettings|. | ||
| 9. [=Wait for all=] |scripts|, with success steps and failure steps both given by: | ||
|
|
||
| 1. Run the <a>responsible event loop</a> specified by |insideSettings|. |
There was a problem hiding this comment.
I think this isn't right. Without an inner event loop, the microtask queue (and thus any awaits) cannot run.
I see two possible semantics here:
- Ignore the promises returned; their errors will be reported appropriately, and that's all one would do with them.
- Run the module scripts "sequentially", waiting for one to complete (i.e. the promise to settle) before moving on to the next.
I think the first of these is probably more correct, since (IIRC) it aligns with what happens if you have multiple TLA-using <script type=module>s.
| 2. If |pendingTaskStruct|'s <a for="pending tasks struct">counter</a> is <b>0</b>, then | ||
| resolve |promise|. | ||
| 2. If |pendingTaskStruct|'s <a for="pending tasks struct">counter</a> is <b>0</b>, then | ||
| resolve |promise|. |
There was a problem hiding this comment.
It looks like you shadowed an existing |promise| variable.
|
@bfgeek what do you think? |
3 tasks
|
This is now whatwg/html#4352. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.