Fix nits/typos from "Allow specs to be represented by a simple string" #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidoust
approved these changes
Jan 31, 2020
| const clarifyErrors = errors => { | ||
| if (!errors || (errors.length < 2)) { | ||
| if (!errors || errors.length < 2) { |
There was a problem hiding this comment.
Do you have favorite code guidelines?
I don't mind either syntax, just wondering if this is more gut feeling or if you're following a specific rule here. For instance, if I run ESLint with no-extra-parens, it's going to report this line but it's also going to report other if lines below where parentheses could also be dropped.
There was a problem hiding this comment.
My favorite style is any style that can be enforced and autofixed by tooling. These parens just seemed clearly unnecessary to me, but if a style rule added them back I wouldn’t mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3