Rename xxxInSeries to seriesXxx #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update renames `previousInSeries` and `nextInSeries` to `seriesPrevious` and `seriesNext` to improve naming consistency with other series properties, which all start with `series`. Note: it is tempting to put these properties under the `series` object, but that object is meant to convey information about the series itself, not about the current spec in the series, which `seriesComposition`, `seriesVersion`, `seriesPrevious` and `seriesNext` hold. In other words, the `series` object is the same for all specs in the series.
dontcallmedom
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update renames
previousInSeriesandnextInSeriestoseriesPreviousandseriesNextto improve naming consistency with other series properties, which all start withseries.It seems tempting to put these properties under the
seriesobject, but that object is meant to convey information about the series itself, not about the current spec in the series, whichseriesComposition,seriesVersion,seriesPreviousandseriesNexthold. In other words, theseriesobject is the same for all specs in the series while other series properties are specific to each one. Or should we not care and put everything underseries(but then that would be inconsistent with the W3C API)?