Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect specs identified in December 7 spec finder #204

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Reflect specs identified in December 7 spec finder #204

merged 3 commits into from
Dec 7, 2020

Conversation

dontcallmedom
Copy link
Member

close #202

@dontcallmedom dontcallmedom requested a review from tidoust December 7, 2020 07:15
tidoust
tidoust approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that I am not entirely clear why some repos/specs need to be under repos, while others need to be under specs. Is there a logical rule to select one or the other when both are in theory possible?

@tidoust tidoust merged commit 18332d3 into master Dec 7, 2020
@dontcallmedom
Copy link
Member Author

the distinction is indeed far from obvious, nor ideal - in some cases, the spec finder starts from a list of repos, in which case it filters them through the repo angle first, then through spec urls; in others, it starts from a list of links, in which case it only looks at spec urls.

@tidoust tidoust deleted the 20201207 branch July 1, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tidoust tidoust tidoust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New specs for review
2 participants
@dontcallmedom @tidoust