Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECMA 262 and TC39 Stage 3 proposals to the list of specs #196

Merged
merged 6 commits into from
Nov 27, 2020
Merged

Conversation

dontcallmedom
Copy link
Member

do not merge for now - reffy is not ready to work with github markdown pages as "specs".

@dontcallmedom dontcallmedom requested review from tidoust and removed request for tidoust November 26, 2020 16:10
@dontcallmedom dontcallmedom force-pushed the ecma branch 3 times, most recently from aac1c6b to 6fc29b1 Compare November 26, 2020 16:34
@dontcallmedom
Copy link
Member Author

now ready

@dontcallmedom dontcallmedom marked this pull request as ready for review November 27, 2020 07:39
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline.

PR mentions that Reffy is not ready to work with GitHub markdown pages as specs. Was it solved by restricting the list to "stage 3" proposals that don't use markdown?

src/compute-shortname.js Outdated Show resolved Hide resolved
@tidoust
Copy link
Member

tidoust commented Nov 27, 2020

I added a couple of tests. I don't see any direct way to test retrieval of the title: I suppose TC39 proposals are not meant to stay as proposals forever so they don't seem to be good candidate URLs for tests, and the title for the main ECMAScript spec actually comes from Specref.

@dontcallmedom
Copy link
Member Author

yes, with stage 3 only proposals, reffy seems to work reasonably well.

@tidoust tidoust merged commit d394894 into master Nov 27, 2020
@tidoust tidoust deleted the ecma branch July 1, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants