Expose filename of the index page #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds a `filename` property to `release` and `nightly` to report the actual filename of the index page, with a view to allowing external code to identify all links to self. The code extracts the filename from the URL if it already appears there. For instance, it extracts the filename `identity.html` from `https://w3c.github.io/webrtc-identity/identity.html`. If the filename is not in the URL, the code uses a trial and error approach: it appends `Overview.html` (most common filename) to the URL and fetches the resulting URL. If that fails, it tries with `index.html` (second most common filename). If that also fails, it tries with `cover.html` (which is essentially only used for the main CSS spec). So far, this is enough to cover all existing specs. Fixes w3c#16.
dontcallmedom
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a
filenameproperty toreleaseandnightlyto report the actual filename of the index page, with a view to allowing external code to identify all links to self.The code extracts the filename from the URL if it already appears there. For instance, it extracts the filename
identity.htmlfromhttps://w3c.github.io/webrtc-identity/identity.html.If the filename is not in the URL, the code uses a trial and error approach: it appends
Overview.html(most common filename) to the URL and fetches the resulting URL. If that fails, it tries withindex.html(second most common filename). If that also fails, it tries withcover.html(which is essentially only used for the main CSS spec). So far, this is enough to cover all existing specs but note the code also looks at theContent-Locationheader as last resort.Fixes #16.