-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role spinbutton: allow empty values, no min, no max, and structure with sibling steppers #813
Conversation
…th sibling steppers For issue #797, allow empty spin buttons by: 1. Changing aria-valuenow to supported from required property. 2. Changing prose to author SHOULD from author MUST specify value for aria-valuenow. 3. Adding aria-valuetext as supported property. For issue #642, allow min and max to be undefined: 1. Change aria-valuemin and aria-valuemax from required to supported properties. 2. Revise prose of paragraph with normative statements. For issue #812: 1. Change description to clearly state that a text field with sibling buttons outside the spinbutton is permitted. 2. Related editorial change to consolidate keyboard requirements into a single paragraph. 3. Other related editorial revisions for clarity.
For future reference, let's aim for one pull request per issue. From my initial triage of what we can already commit to the stable (Working Draft) branch, the issue #812 stuff doesn't strike me as something for which we need Core-AAM changes or tests; it's purely authoring. On the other hand, this same pull request changed the default value of Do we block merging this entire set of changes into stable because of two single-line (but significant) changes? Do we manually break apart the changes and commit parts, but leave parts out? Neither is good imho. Solution: Please don't do this in the future. :) :) |
…th sibling steppers (#813) * Change prose to author SHOULD from author MUST specify value for aria-valuenow. * Change aria-valuemin and aria-valuemax from required to supported properties. * Revise prose of paragraph with normative statements. * Change description to clearly state that a text field with sibling buttons outside the spinbutton is permitted. * Make related editorial change to consolidate keyboard requirements into a single paragraph. * Make other related editorial revisions for clarity.
Most of the changes made for pull request #813 were editorial or were specific to authoring and thus did not require any changes to Core AAM or testing related to exit criteria. Two of the changes, however did not fall into this category namely: * Make aria-valuetext a supported property of spinbutton * Change the default value of aria-valuenow from 0 to "there is no current value" Once we have ensured mapping changes have been made, tests are in place, and implementations present or planned, we can merge the above into the stable branch.
Most of the changes made for pull request #813 were editorial or were specific to authoring and thus did not require any changes to Core AAM or testing related to exit criteria. Two of the changes, however did not fall into this category namely: * Make aria-valuetext a supported property of spinbutton * Change the default value of aria-valuenow from 0 to "there is no current value" Once we have ensured mapping changes have been made, tests are in place, and implementations present or planned, we can merge the above into the stable branch.
The spinbutton role already supported aria-valuetext as a consequence of subclassing the abstract role range. But it was added as an explicitly- supported property of spinbutton as a consequence of #813. This part of the change hadn't been merged due to the mistaken conclusion that new tests would be needed.
For issue #797, allow empty spin buttons by:
For issue #642, allow min and max to be undefined:
For issue #812:
Preview | Diff