Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [CEReactions] to IDL. #1766

Merged
merged 2 commits into from
Aug 30, 2022
Merged

add [CEReactions] to IDL. #1766

merged 2 commits into from
Aug 30, 2022

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Jul 13, 2022 •
edited by pr-preview bot
Loading

Resolves #1242

Preview | Diff

@cookiecrook
Copy link
Contributor Author

cc @smaug----

@spectranaut spectranaut self-requested a review July 14, 2022 17:23
@pkra pkra mentioned this pull request Jul 16, 2022
Closed
@mrego
Copy link
Member

mrego commented Jul 19, 2022

JFYI, all implementations use CEReactions:

@cookiecrook
Copy link
Contributor Author

@aleventhal requested surrogate review from @domenic and @smaug----

domenic
domenic approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing this.

@cookiecrook
Copy link
Contributor Author

Thanks all. @spectranaut I think this is ready to be merged.

spectranaut
spectranaut approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because all browsers implemented

@spectranaut
Copy link
Contributor

@pkra can you merge? :)

@pkra pkra self-assigned this Aug 26, 2022
@jnurthen jnurthen merged commit 483334d into main Aug 30, 2022
github-actions bot added a commit that referenced this pull request Aug 30, 2022
@cookiecrook @github-actions
add [CEReactions] to IDL. (#1766)
9bf3ce5 
SHA: 483334d
Reason: push, by @jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Aug 31, 2022
@cookiecrook @jnurthen
add [CEReactions] to IDL. (#1766)
2cd15a0 
* add [CEReactions] to IDL.
Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@cookiecrook @jnurthen
add [CEReactions] to IDL. (#1766)
e67bcea 
* add [CEReactions] to IDL.
Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut spectranaut approved these changes

@domenic domenic domenic approved these changes

@smaug---- smaug---- smaug---- approved these changes

@aleventhal aleventhal Awaiting requested review from aleventhal

@asurkov asurkov Awaiting requested review from asurkov

Assignees

@pkra pkra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARIA IDL miss CEReaction attribute
7 participants
@cookiecrook @mrego @spectranaut @domenic @smaug---- @pkra @jnurthen