Update required owned elements and required context role #1454

smhigley · 2021-04-13T19:41:57Z

Resolves #1033

Updates "Required Owned Elements" to "Allowed Child Elements", and "Required Context Role" to "Required Parent Role", with added definitions for parent, child, controlled element, and controlling element.

I did some support tests for having intermediate elements in composite widgets, and secondary actions in composite widgets, here: https://cdpn.io/smhigley/debug/vYgLZgK

This is still a POC, so I didn't update all the references to required owned elements/context role. Hopefully that makes it a bit easier to see the relevant diffs for discussion.

Should also resolve #1486

PR merge check list

Related Core AAM Issue/PR: N/A
Related AccName Issue/PR: N/A
Related APG Issue/PR: N/A (expandable listbox example already removed)
Any other dependent changes? N/A
validator tests: Add validator tests for required owned elements > allowed a11y roles change #1917
WPT tests: Aria issue to discuss
Browser implementations (link to issue or when done, link to commit):
- WebKit: n/a
- Gecko: n/a
- Blink: n/a
Does this need AT implementations? no

Preview | Diff

scottaohara

since this is still a draft, just a few comments/suggestions. hope they're helpful

common/terms.html

index.html

smhigley · 2021-04-30T06:02:15Z

I updated the PR based on the comments, updated all references to "required owned elements"/"required context role", and moved the aria-controls allowed child stuff to a separate branch. It should be ready for a full review now.

common/terms.html

jnurthen · 2021-05-11T22:47:25Z

index.html

@@ -10909,7 +10909,7 @@ <h2>Definitions of States and Properties (all aria-* attributes)</h2>
 				<p>The default value of <code>aria-busy</code> is <code>false</code> for all elements. When <code>aria-busy</code> is <code>true</code> for an element, assistive technologies MAY ignore changes to content owned by that element and then process all changes made during the busy period as a single, atomic update when <code>aria-busy</code> becomes <code>false</code>.</p>
 				<p>If it is necessary to make multiple additions, modifications, or removals within a container element that is already either partially or fully rendered, authors MAY set <code>aria-busy</code> to <code>true</code> on the container element before the first change, and then set it to <code>false</code> when the last change is complete. For example, if multiple changes to a <a>live region</a> should be spoken as a single unit of speech, authors MAY set <code>aria-busy</code> to <code>true</code> while the changes are being made and then set it to <code>false</code> when the changes are complete and ready to be spoken.</p>
 				<p>If an element with role <rref>feed</rref> is marked busy, assistive technologies MAY defer rendering changes that occur inside the <code>feed</code> with the exception of user-initiated changes that occur inside the <rref>article</rref> that the user is reading during the busy period.</p>
-				<p>If changes to a rendered <rref>widget</rref> would create a state where the <rref>widget</rref> is missing <a href="#mustContain">required owned elements</a> during script execution, authors MUST set <code>aria-busy</code> to <code>true</code> on the <rref>widget</rref> during the update process. For example, if a rendered tree grid required a set of simultaneous updates to multiple discontiguous branches, an alternative to replacing the complete tree element with a single update would be to mark the tree busy while each of the branches are modified.</p>
+				<p>If changes to a rendered <rref>widget</rref> would create a state where the <rref>widget</rref> is modifying <a href="#mustContain">allowed child roles</a> during script execution, authors MAY set <code>aria-busy</code> to <code>true</code> on the <rref>widget</rref> during the update process. For example, if a rendered tree grid required a set of simultaneous updates to multiple discontiguous branches, an alternative to replacing the complete tree element with a single update would be to mark the tree busy while each of the branches are modified.</p>


Can we just remove this. Does setting aria-busy in this state actually do anything?

I'm happy to remove it, I just didn't want to muddy this PR with other changes if they'd be controversial 😅

jnurthen · 2021-05-11T22:50:30Z

Please also move the new terms to index.html. The content of terms.html has been moved there. You'll need to pull the changes from main though to pick this up.

smhigley · 2021-05-13T18:27:56Z

All the previous comments should be addressed. @scottaohara / @aleventhal, how does it look now?

smhigley · 2021-05-13T18:33:16Z

also pinging @jcsteh because for some reason github isn't letting me add him to the reviewers ¯_(ツ)_/¯

index.html

jcsteh · 2021-05-17T04:52:59Z

index.html

-			<p class="note">An element with a <a href="#subclassroles">subclass role</a> of the 'required owned element' does not fulfill this requirement. For example, the <rref>listbox</rref> role requires ownership of an element using the <rref>option</rref> or <rref>group</rref> role. Although the <rref>group</rref> role is the superclass of <rref>row</rref>, adding an <a>owned</a> element with a role of <rref>row</rref> will not fulfill the requirement that <rref>listbox</rref> owns an <rref>option</rref> or a <rref>group</rref>.</p>
+			<h3>Allowed Child Roles</h3>
+			<p>Any <a>element</a> that is a direct <a>child</a> of the element with this <a>role</a>. For example, an element with the role <rref>list</rref> may own elements with the role <rref>listitem</rref>, but not elements with the role <rref>option</rref>.</p>
+			<p>To determine whether an element is the direct <a>child</a> of a role, <a>user agents</a> MUST ignore any elements with the role <rref>generic</rref> or <rref>presentation</rref>.</p>


It's definitely good that we're clarifying what happens concerning generics here. That will clear up implementer confusion like this.

Again, this is clear if you read the definition of "child", but I wonder whether this could be misconstrued as discussing siblings rather than intervening (depth-wise) elements. Perhaps we could clarify this by saying "intervening elements" here?

Also, I assume this isn't a statement about whether intervening generics get exposed in the a11y tree or not, but rather, only a statement about what is considered valid (thus impacting implicit posinset/setsize calculation, etc.)? Pruning intervening generics would be a much bigger change for implementers which would need further discussion.

I updated to "intervening elements" -- thanks for the suggestion, I like that better :).

And yup! This is guidance on allowed role structure, and isn't prescriptive of API mappings. The only change is implementers would officially need to support e.g. listbox > generic > option (which most already do), but could do so with or without pruning the generic.

smhigley · 2021-09-15T19:55:50Z

Just want to ping @jcsteh, @scottaohara, and @aleventhal on this to see if the updates have addressed past comments as desired :)

scottaohara

wrote these review comments some time ago... sorry for the delay.

index.html

common/terms.html

index.html

jnurthen · 2022-05-02T23:20:26Z

should also resolve #1486

jnurthen · 2022-06-09T17:43:09Z

@smhigley would this PR take care of #1300 ?

Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>

smhigley · 2023-04-13T19:14:46Z

@spectranaut, @scottaohara, and @adampage -- I updated with a lot of the suggestions you mentioned, and some comments. Let me know what you think!

spectranaut

Looks great!

I don't think there are any changes to the validator tests, right, Sarah? Seems to me like this is all clarification/rewording of existing "author MUST" requirements.

smhigley · 2023-04-13T20:28:32Z

@spectranaut I think the validator change would be checking something like this:

<div role="listbox">
  <div>
    <div role="option">hi I'm valid now</div>
  </div>
</div>

spectranaut · 2023-04-13T21:09:53Z

Oh right what was I thinking, we even talked about this. I just got so wrapped up in the "rewrite" and new terms I forgot about this key change XD

Do you want to do that here, or in a follow up issue? If a follow issue, please make one, otherwise, you can add a validator test here.

index.html

Co-authored-by: Adam Page <adamfpage@gmail.com>

smhigley · 2023-04-14T19:14:50Z

@spectranaut issue is made! #1917

spectranaut · 2023-04-14T19:25:28Z

@pkra or @jnurthen do you think we can merge this? :)

spectranaut

I spoke too soon once again! The new CI check caught an errant "may", we need to fix that THEN I think it is ready for merge

index.html

Co-authored-by: Valerie Young <spectranaut@igalia.com>

index.html

jnurthen

I think a #mustContain was missed

Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>

outdated

SHA: 232ae78 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Updates "Required Owned Elements" to "Allowed Child Elements", and "Required Context Role" to "Required Parent Role", with added definitions for parent, child, controlled element, and controlling element.

scottaohara reviewed Apr 14, 2021

View reviewed changes

common/terms.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

smhigley marked this pull request as ready for review April 30, 2021 06:02

jnurthen approved these changes May 11, 2021

View reviewed changes

common/terms.html Outdated Show resolved Hide resolved

jnurthen reviewed May 11, 2021

View reviewed changes

smhigley force-pushed the req-owned-elements branch from 2480d3c to 5607c6c Compare May 13, 2021 17:30

smhigley requested a review from cyns May 13, 2021 18:29

scottaohara mentioned this pull request May 15, 2021

Allowed children of role=tablist includes any role including tabpanel? #1486

Closed

jcsteh reviewed May 17, 2021

View reviewed changes

smhigley mentioned this pull request Jun 3, 2021

Draft: Add secondary action buttons as allowed child roles #1498

Closed

smhigley force-pushed the req-owned-elements branch from 4dc74da to b210f3c Compare July 2, 2021 23:27

scottaohara reviewed Nov 3, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

jnurthen reviewed Nov 13, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

pkra mentioned this pull request Nov 18, 2021

Question: role presentation on non-semantic elements - why? #1647

Closed

smhigley requested review from aleventhal and scottaohara November 21, 2021 05:07

scottaohara reviewed Nov 21, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

pkra reviewed Nov 22, 2021

View reviewed changes

common/terms.html Outdated Show resolved Hide resolved

pkra reviewed Nov 22, 2021

View reviewed changes

common/terms.html Outdated Show resolved Hide resolved

pkra reviewed Nov 22, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

pkra added this to the ARIA 1.3 milestone Jan 12, 2022

scottaohara mentioned this pull request Mar 10, 2022

Define "scoped" or reuse another existing term? w3c/html-aam#375

Open

snowystinger mentioned this pull request Apr 14, 2022

Custom sticky header and footer for popover and tray adobe/react-spectrum#3020

Closed

pkra added the merge conflict label Apr 29, 2022

smhigley and others added 2 commits April 13, 2023 11:43

Use role none instead of presentation

aacf59c

Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>

updates based on comments

e98813c

smhigley force-pushed the req-owned-elements branch from 922d75e to e98813c Compare April 13, 2023 18:49

spectranaut approved these changes Apr 13, 2023

View reviewed changes

adampage approved these changes Apr 13, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Remove rogue git typo

76aa663

Co-authored-by: Adam Page <adamfpage@gmail.com>

smhigley mentioned this pull request Apr 14, 2023

Add validator tests for required owned elements > allowed a11y roles change #1917

Open

spectranaut previously requested changes Apr 14, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

cookiecrook previously requested changes Apr 18, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

spectranaut reviewed Apr 26, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

jnurthen and others added 2 commits April 26, 2023 13:24

Update index.html

fe015ce

Co-authored-by: Valerie Young <spectranaut@igalia.com>

Merge remote-tracking branch 'origin/main' into req-owned-elements

9f35b78

jnurthen reviewed Apr 26, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

jnurthen reviewed Apr 26, 2023

View reviewed changes

spectranaut mentioned this pull request Apr 28, 2023

Audit use of term "owns", in "owned element" and "owning element" #1927

Closed

Update index.html

1be7640

Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>

spectranaut merged commit 232ae78 into main May 1, 2023

github-actions bot added a commit that referenced this pull request May 1, 2023

Update required owned elements and required context role (#1454)

a3ffa5c

SHA: 232ae78 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

spectranaut mentioned this pull request May 1, 2023

Inconsistent use of "owned by" #1161

Open

YusukeHirao mentioned this pull request May 4, 2023

Supporting for the ARIA 1.3 new structured rule markuplint/markuplint#970

Open

spectranaut mentioned this pull request Sep 4, 2023

Editorial: In favor of "owned element" and "owning element", uses "accessibility parent", "accessibility child" and "accessibility descendant" #2010

Merged

scottaohara mentioned this pull request Sep 8, 2023

menuitem doesn't have presentational children? #1711

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update required owned elements and required context role #1454

Update required owned elements and required context role #1454

smhigley commented Apr 13, 2021 •

edited by pr-preview bot

Loading

scottaohara left a comment

smhigley commented Apr 30, 2021

jnurthen May 11, 2021

smhigley May 13, 2021

jnurthen commented May 11, 2021

smhigley commented May 13, 2021

smhigley commented May 13, 2021

jcsteh May 17, 2021

smhigley Jul 1, 2021 •

edited

Loading

smhigley commented Sep 15, 2021

scottaohara left a comment

jnurthen commented May 2, 2022

jnurthen commented Jun 9, 2022

smhigley commented Apr 13, 2023

spectranaut left a comment

smhigley commented Apr 13, 2023

spectranaut commented Apr 13, 2023

smhigley commented Apr 14, 2023

spectranaut commented Apr 14, 2023

spectranaut left a comment

jnurthen left a comment

Update required owned elements and required context role #1454

Update required owned elements and required context role #1454

Conversation

smhigley commented Apr 13, 2021 • edited by pr-preview bot Loading

PR merge check list

scottaohara left a comment

Choose a reason for hiding this comment

smhigley commented Apr 30, 2021

jnurthen May 11, 2021

Choose a reason for hiding this comment

smhigley May 13, 2021

Choose a reason for hiding this comment

jnurthen commented May 11, 2021

smhigley commented May 13, 2021

smhigley commented May 13, 2021

jcsteh May 17, 2021

Choose a reason for hiding this comment

smhigley Jul 1, 2021 • edited Loading

Choose a reason for hiding this comment

smhigley commented Sep 15, 2021

scottaohara left a comment

Choose a reason for hiding this comment

jnurthen commented May 2, 2022

jnurthen commented Jun 9, 2022

smhigley commented Apr 13, 2023

spectranaut left a comment

Choose a reason for hiding this comment

smhigley commented Apr 13, 2023

spectranaut commented Apr 13, 2023

smhigley commented Apr 14, 2023

spectranaut commented Apr 14, 2023

spectranaut left a comment

Choose a reason for hiding this comment

jnurthen left a comment

Choose a reason for hiding this comment

smhigley commented Apr 13, 2021 •

edited by pr-preview bot

Loading

smhigley Jul 1, 2021 •

edited

Loading