Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA 1.1 Combobox Examples: Use for attribute on label element instead of aria-labelledby on input element #746

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

sh0ji
Copy link
Contributor

@sh0ji sh0ji commented Jun 27, 2018

Fixes #542.

Copy link
Contributor

@jessebeach jessebeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@mcking65
Copy link
Contributor

I've added a commit to update the documentation table to remove the row for aria-labelledby on the input and replace it with a row for the id attribute that documents the labeling method.

@mcking65 mcking65 changed the title Use label[for] where appropriate ARIA 1.1 Combobox Examples: Use for attribute on label element instead of aria-labelledby on input element Jul 11, 2018
@mcking65 mcking65 merged commit 72f4bb2 into w3c:master Jul 11, 2018
@sh0ji sh0ji deleted the 542-fix branch November 12, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants